Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing properties to zfs allow manpage #12402

Closed
wants to merge 1 commit into from
Closed

Add missing properties to zfs allow manpage #12402

wants to merge 1 commit into from

Conversation

vaclavskala
Copy link
Contributor

Motivation and Context

Make zfs allow manpage and zfs allow error output consistent.

Description

Add to manpage properties mentioned only in zfs allow error output (output of zfs allow command without any parameters).
Also changed in manpage nonexistent subcommands "load" and "change" to real subcommands "load-key" and "change-key".

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • [ x] Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • [ x] I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • [ x] All commit messages are properly formatted and contain Signed-off-by.

@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Type: Documentation Indicates a requested change to the documentation labels Jul 21, 2021
behlendorf
behlendorf approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation update!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 26, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
@vaclavskala @behlendorf
Add missing properties to zfs allow manpage
fc42a38 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Václav Skála <[email protected]>
Closes openzfs#12402
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@vaclavskala @behlendorf
Add missing properties to zfs allow manpage
5a2eef0 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Václav Skála <[email protected]>
Closes openzfs#12402
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@vaclavskala
Add missing properties to zfs allow manpage
551b17e 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Václav Skála <[email protected]>
Closes openzfs#12402
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@vaclavskala @behlendorf
Add missing properties to zfs allow manpage
8c80641 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Václav Skála <[email protected]>
Closes openzfs#12402
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
@vaclavskala @behlendorf
Add missing properties to zfs allow manpage
051658e 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Václav Skála <[email protected]>
Closes #12402
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@vaclavskala @tonyhutter
Add missing properties to zfs allow manpage
898b1e1 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Václav Skála <[email protected]>
Closes openzfs#12402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaclavskala @behlendorf